Use umbrella instead of a direct include in react/renderer/telemetry module (#58553) - #58553
Open
j-piasecki wants to merge 3 commits into
Open
j-piasecki wants to merge 3 commits into
j-piasecki wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
j-piasecki
force-pushed
the
export-D120316919
branch
3 times, most recently
from
September 21, 2026 06:43
2f3ef68 to
58265dc
Compare
j-piasecki
force-pushed
the
export-D120316919
branch
from
September 22, 2026 13:17
58265dc to
4230dca
Compare
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120316919. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 22, 2026
…module (react#58553) Summary: Pull Request resolved: react#58553 Changelog: [Internal] Update the react/renderer/telemetry module to use the `React/Utils.h` umbrella include instead of a direct one. Differential Revision: D120316919
j-piasecki
force-pushed
the
export-D120316919
branch
from
September 22, 2026 13:23
4230dca to
601c1ec
Compare
meta-codesync
Bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…module (react#58553) Summary: Changelog: [Internal] Update the react/renderer/telemetry module to use the `React/Utils.h` umbrella include instead of a direct one. Differential Revision: D120316919
j-piasecki
force-pushed
the
export-D120316919
branch
from
September 29, 2026 07:37
601c1ec to
c48dad0
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…module (react#58553) Summary: Pull Request resolved: react#58553 Changelog: [Internal] Update the react/renderer/telemetry module to use the `React/Utils.h` umbrella include instead of a direct one. Differential Revision: D120316919
j-piasecki
force-pushed
the
export-D120316919
branch
from
September 29, 2026 07:46
c48dad0 to
3712431
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
…module (react#58553) Summary: Changelog: [Internal] Update the react/renderer/telemetry module to use the `React/Utils.h` umbrella include instead of a direct one. Differential Revision: D120316919
j-piasecki
force-pushed
the
export-D120316919
branch
from
September 29, 2026 08:34
3712431 to
40c0301
Compare
cortinico
approved these changes
Sep 29, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
…module (react#58551) Summary: Changelog: [Internal] Update the react/renderer/scheduler module to use the `React/RendererCore.h`, `React/Utils.h`, and `React/ComponentRegistry.h` umbrella includes instead of direct ones. Differential Revision: D120315036
…ct#58550) Summary: Changelog: [Internal] Part of the C++ stable API migration to umbrella includes. Fixes tier reachability violations in the `react/runtime` module. The headers in this module are "for frameworks" tier (they include `<react/cxxstableapi/FrameworksGuard.h>`), but they reached public-tier modules through fine-grained includes: `<ReactCommon/CallInvoker.h>`, `<ReactCommon/SchedulerPriority.h>`, `<ReactCommon/RuntimeExecutor.h>` and `<cxxreact/JSBigString.h>`. Each of these is protected by `<react/cxxstableapi/UmbrellaGuard.h>`. Exported headers are preprocessed in the consumer's translation unit, so a consumer building with `RN_STRICT_API` would hit the guard through these transitive includes. `RN_ALLOW_FRAMEWORKS` does not suppress the guard. This change switches the five affected headers (`BridgelessNativeMethodCallInvoker.h`, `BufferedRuntimeExecutor.h`, `CallInvokerImpl.h`, `ReactInstance.h`, `TimerManager.h`) to the `<React/CallInvoker.h>`, `<React/RuntimeExecutor.h>` and `<React/JSBigString.h>` umbrellas. Each umbrella scopes `RN_UMBRELLA_CONTEXT` around its includes, so the guard accepts them. `<ReactCommon/SchedulerPriority.h>` has no include of its own anymore because `<React/CallInvoker.h>` re-exports it. The umbrellas are supersets of the headers they replace, so every previously visible declaration stays available and there is no functional change. Out of scope: `ReactInstance.cpp` and the module's C++ tests keep the fine-grained includes. They are compiled only within React Native's own build and are never preprocessed by consumers, which matches the umbrellas' documented guidance. Other modules are migrated in separate changes. Reviewed By: cortinico Differential Revision: D120316197
…module (react#58553) Summary: Changelog: [Internal] Update the react/renderer/telemetry module to use the `React/Utils.h` umbrella include instead of a direct one. Reviewed By: cortinico Differential Revision: D120316919
j-piasecki
force-pushed
the
export-D120316919
branch
from
September 29, 2026 11:11
40c0301 to
672ec01
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Update the react/renderer/telemetry module to use the
React/Utils.humbrella include instead of a direct one.Reviewed By: cortinico
Differential Revision: D120316919